[INFO] cloning repository https://github.com/nsmryan/RustTcodTutorial
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nsmryan/RustTcodTutorial" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsmryan%2FRustTcodTutorial", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsmryan%2FRustTcodTutorial'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 73c1f608292044de140475a5a3ee57179a101f23
[INFO] checking nsmryan/RustTcodTutorial against master#158f00a1c5175648af6f6099b075f78d1d014a28 for pr-121251
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsmryan%2FRustTcodTutorial" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/nsmryan/RustTcodTutorial on toolchain 158f00a1c5175648af6f6099b075f78d1d014a28
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+158f00a1c5175648af6f6099b075f78d1d014a28" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/nsmryan/RustTcodTutorial
[INFO] finished tweaking git repo https://github.com/nsmryan/RustTcodTutorial
[INFO] tweaked toml for git repo https://github.com/nsmryan/RustTcodTutorial written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] crate git repo https://github.com/nsmryan/RustTcodTutorial already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+158f00a1c5175648af6f6099b075f78d1d014a28" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded logging_timer_proc_macros v1.1.0
[INFO] [stderr]   Downloaded logging_timer v1.1.0
[INFO] [stderr]   Downloaded symmetric-shadowcasting v0.2.0
[INFO] [stderr]   Downloaded gumdrop_derive v0.8.0
[INFO] [stderr]   Downloaded wfc-rs v0.6.1
[INFO] [stderr]   Downloaded gumdrop v0.8.0
[INFO] [stderr]   Downloaded pathfinding v2.0.5
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+158f00a1c5175648af6f6099b075f78d1d014a28" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7d23255e8c3e1d509b987513caeed24c44762177184f3a0d7ad34e061fa8bb35
[INFO] running `Command { std: "docker" "start" "-a" "7d23255e8c3e1d509b987513caeed24c44762177184f3a0d7ad34e061fa8bb35", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7d23255e8c3e1d509b987513caeed24c44762177184f3a0d7ad34e061fa8bb35", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7d23255e8c3e1d509b987513caeed24c44762177184f3a0d7ad34e061fa8bb35", kill_on_drop: false }`
[INFO] [stdout] 7d23255e8c3e1d509b987513caeed24c44762177184f3a0d7ad34e061fa8bb35
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+158f00a1c5175648af6f6099b075f78d1d014a28" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] da53ec10afca2042e30b36b9efb0432bc0352087f27823c119f82feaa77c8849
[INFO] running `Command { std: "docker" "start" "-a" "da53ec10afca2042e30b36b9efb0432bc0352087f27823c119f82feaa77c8849", kill_on_drop: false }`
[INFO] [stderr]    Compiling autocfg v1.0.1
[INFO] [stderr]    Compiling proc-macro2 v1.0.36
[INFO] [stderr]    Compiling unicode-xid v0.2.2
[INFO] [stderr]    Compiling syn v1.0.85
[INFO] [stderr]    Compiling memchr v2.5.0
[INFO] [stderr]    Compiling libc v0.2.112
[INFO] [stderr]    Compiling serde_derive v1.0.133
[INFO] [stderr]    Compiling serde v1.0.133
[INFO] [stderr]     Checking cfg-if v1.0.0
[INFO] [stderr]    Compiling regex-syntax v0.6.26
[INFO] [stderr]     Checking hashbrown v0.11.2
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling indexmap v1.8.0
[INFO] [stderr]     Checking aho-corasick v0.7.18
[INFO] [stderr]    Compiling num-integer v0.1.44
[INFO] [stderr]    Compiling quote v1.0.14
[INFO] [stderr]     Checking linked-hash-map v0.5.4
[INFO] [stderr]    Compiling once_cell v1.12.0
[INFO] [stderr]    Compiling log v0.4.14
[INFO] [stderr]     Checking yaml-rust v0.4.5
[INFO] [stderr]    Compiling num-rational v0.3.2
[INFO] [stderr]     Checking ryu v1.0.9
[INFO] [stderr]     Checking either v1.6.1
[INFO] [stderr]     Checking itertools v0.9.0
[INFO] [stderr]     Checking fixedbitset v0.3.2
[INFO] [stderr]     Checking lazy_static v1.4.0
[INFO] [stderr]     Checking smallvec v1.8.0
[INFO] [stderr]     Checking thread-id v3.3.0
[INFO] [stderr]     Checking simple-logging v2.0.2
[INFO] [stderr]    Compiling regex v1.5.6
[INFO] [stderr]    Compiling cfg-if v0.1.10
[INFO] [stderr]    Compiling version-compare v0.0.10
[INFO] [stderr]     Checking getrandom v0.2.4
[INFO] [stderr]     Checking symmetric-shadowcasting v0.2.0
[INFO] [stderr]     Checking byteorder v1.4.3
[INFO] [stderr]    Compiling cc v1.0.72
[INFO] [stderr]    Compiling sdl2-sys v0.34.5
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]     Checking pathfinding v2.0.5
[INFO] [stderr]     Checking ppv-lite86 v0.2.16
[INFO] [stderr]    Compiling sdl2 v0.34.5
[INFO] [stderr]     Checking rmp v0.8.10
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking bitflags v1.3.2
[INFO] [stderr]     Checking bmp v0.5.0
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]    Compiling wfc-rs v0.6.1
[INFO] [stderr]    Compiling structmeta-derive v0.1.5
[INFO] [stderr]    Compiling logging_timer_proc_macros v1.1.0
[INFO] [stderr]    Compiling gumdrop_derive v0.8.0
[INFO] [stderr]     Checking logging_timer v1.1.0
[INFO] [stderr]    Compiling structmeta v0.1.5
[INFO] [stderr]     Checking gumdrop v0.8.0
[INFO] [stderr]    Compiling parse-display-derive v0.5.5
[INFO] [stderr]     Checking parse-display v0.5.5
[INFO] [stderr]     Checking serde_yaml v0.8.23
[INFO] [stderr]     Checking rmp-serde v0.15.5
[INFO] [stderr]     Checking roguelike_utils v0.1.0 (/opt/rustwide/workdir/roguelike_utils)
[INFO] [stderr]     Checking roguelike_map v0.1.0 (/opt/rustwide/workdir/roguelike_map)
[INFO] [stderr]     Checking roguelike_core v0.1.0 (/opt/rustwide/workdir/roguelike_core)
[INFO] [stderr]     Checking roguelike_draw v0.1.0 (/opt/rustwide/workdir/roguelike_draw)
[INFO] [stdout] warning: unused import: `std::str::FromStr`
[INFO] [stdout]  --> roguelike_draw/src/drawcmd.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::str::FromStr;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::io::BufRead`
[INFO] [stdout]  --> roguelike_draw/src/drawcmd.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::io::BufRead;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `SpriteKey`
[INFO] [stdout]   --> roguelike_draw/src/drawcmd.rs:16:32
[INFO] [stdout]    |
[INFO] [stdout] 16 | use crate::animation::{Sprite, SpriteKey};
[INFO] [stdout]    |                                ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `lookup_spritekey`, `parse_atlas_file`
[INFO] [stdout]   --> roguelike_draw/src/drawcmd.rs:18:39
[INFO] [stdout]    |
[INFO] [stdout] 18 | use crate::spritesheet::{SpriteSheet, lookup_spritekey, parse_atlas_file};
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `PlayerDirection`
[INFO] [stdout]  --> roguelike_draw/src/spritesheet.rs:7:21
[INFO] [stdout]   |
[INFO] [stdout] 7 | use roguelike_map::{PlayerDirection};
[INFO] [stdout]   |                     ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Sprite`
[INFO] [stdout]  --> roguelike_draw/src/spritesheet.rs:9:24
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::animation::{Sprite, SpriteKey};
[INFO] [stdout]   |                        ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Panel`
[INFO] [stdout]   --> roguelike_draw/src/spritesheet.rs:10:20
[INFO] [stdout]    |
[INFO] [stdout] 10 | use crate::panel::{Panel};
[INFO] [stdout]    |                    ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::str::FromStr`
[INFO] [stdout]  --> roguelike_draw/src/drawcmd.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::str::FromStr;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::io::BufRead`
[INFO] [stdout]  --> roguelike_draw/src/drawcmd.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::io::BufRead;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `SpriteKey`
[INFO] [stdout]   --> roguelike_draw/src/drawcmd.rs:16:32
[INFO] [stdout]    |
[INFO] [stdout] 16 | use crate::animation::{Sprite, SpriteKey};
[INFO] [stdout]    |                                ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `lookup_spritekey`, `parse_atlas_file`
[INFO] [stdout]   --> roguelike_draw/src/drawcmd.rs:18:39
[INFO] [stdout]    |
[INFO] [stdout] 18 | use crate::spritesheet::{SpriteSheet, lookup_spritekey, parse_atlas_file};
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `PlayerDirection`
[INFO] [stdout]  --> roguelike_draw/src/spritesheet.rs:7:21
[INFO] [stdout]   |
[INFO] [stdout] 7 | use roguelike_map::{PlayerDirection};
[INFO] [stdout]   |                     ^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Sprite`
[INFO] [stdout]  --> roguelike_draw/src/spritesheet.rs:9:24
[INFO] [stdout]   |
[INFO] [stdout] 9 | use crate::animation::{Sprite, SpriteKey};
[INFO] [stdout]   |                        ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Panel`
[INFO] [stdout]   --> roguelike_draw/src/spritesheet.rs:10:20
[INFO] [stdout]    |
[INFO] [stdout] 10 | use crate::panel::{Panel};
[INFO] [stdout]    |                    ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 7 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 7 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> roguelike_core/src/level.rs:100:41
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           for offset in reach.move_with_reach(&direction) {
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           while let Some(offset) = reach.move_with_reach(&direction) {
[INFO] [stdout]     |                           ~~~~~~~~~~~~~~~      ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           if let Some(offset) = reach.move_with_reach(&direction) {
[INFO] [stdout]     |                           ~~~~~~~~~~~~      ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> roguelike_core/src/level.rs:100:41
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           for offset in reach.move_with_reach(&direction) {
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           while let Some(offset) = reach.move_with_reach(&direction) {
[INFO] [stdout]     |                           ~~~~~~~~~~~~~~~      ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 100 |                           if let Some(offset) = reach.move_with_reach(&direction) {
[INFO] [stdout]     |                           ~~~~~~~~~~~~      ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 1 warning emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 1 warning emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking roguelike_engine v0.1.0 (/opt/rustwide/workdir/roguelike_engine)
[INFO] [stderr]     Checking roguelike_display v0.1.0 (/opt/rustwide/workdir/roguelike_display)
[INFO] [stdout] warning: unused import: `roguelike_core::utils::*`
[INFO] [stdout]   --> roguelike_engine/src/step.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | use roguelike_core::utils::*;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `roguelike_core::movement::*`
[INFO] [stdout]   --> roguelike_engine/src/step.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 | use roguelike_core::movement::*;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]     --> roguelike_display/src/render.rs:1216:21
[INFO] [stdout]      |
[INFO] [stdout] 1216 |                 let mut color = color;
[INFO] [stdout]      |                     ----^^^^^
[INFO] [stdout]      |                     |
[INFO] [stdout]      |                     help: remove this `mut`
[INFO] [stdout]      |
[INFO] [stdout]      = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]     --> roguelike_display/src/render.rs:1216:21
[INFO] [stdout]      |
[INFO] [stdout] 1216 |                 let mut color = color;
[INFO] [stdout]      |                     ----^^^^^
[INFO] [stdout]      |                     |
[INFO] [stdout]      |                     help: remove this `mut`
[INFO] [stdout]      |
[INFO] [stdout]      = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 1 warning emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 1 warning emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `index`
[INFO] [stdout]    --> roguelike_engine/src/map_construct.rs:143:17
[INFO] [stdout]     |
[INFO] [stdout] 143 |             for index in 0..1000 {
[INFO] [stdout]     |                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_index`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `index`
[INFO] [stdout]    --> roguelike_engine/src/map_construct.rs:143:17
[INFO] [stdout]     |
[INFO] [stdout] 143 |             for index in 0..1000 {
[INFO] [stdout]     |                 ^^^^^ help: if this is intentional, prefix it with an underscore: `_index`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> roguelike_engine/src/resolve.rs:204:25
[INFO] [stdout]     |
[INFO] [stdout] 204 |             if let Some(mut status) = game.level.entities.status.get_mut(&entity_id) {
[INFO] [stdout]     |                         ----^^^^^^
[INFO] [stdout]     |                         |
[INFO] [stdout]     |                         help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> roguelike_engine/src/resolve.rs:204:25
[INFO] [stdout]     |
[INFO] [stdout] 204 |             if let Some(mut status) = game.level.entities.status.get_mut(&entity_id) {
[INFO] [stdout]     |                         ----^^^^^^
[INFO] [stdout]     |                         |
[INFO] [stdout]     |                         help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> roguelike_engine/src/step.rs:91:21
[INFO] [stdout]    |
[INFO] [stdout] 91 |         if let Some(mut status) = game.level.entities.status.get_mut(entity_id) {
[INFO] [stdout]    |                     ----^^^^^^
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> roguelike_engine/src/step.rs:91:21
[INFO] [stdout]    |
[INFO] [stdout] 91 |         if let Some(mut status) = game.level.entities.status.get_mut(entity_id) {
[INFO] [stdout]    |                     ----^^^^^^
[INFO] [stdout]    |                     |
[INFO] [stdout]    |                     help: remove this `mut`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `col`
[INFO] [stdout]    --> roguelike_engine/src/step.rs:525:9
[INFO] [stdout]     |
[INFO] [stdout] 525 |     let col = make_column(&mut game.level.entities, &game.config, col_pos, &mut game.msg_log);
[INFO] [stdout]     |         ^^^ help: if this is intentional, prefix it with an underscore: `_col`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]     --> roguelike_engine/src/resolve.rs:1052:25
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         for other_id in level.has_entity(interact_pos) {
[INFO] [stdout]      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         while let Some(other_id) = level.has_entity(interact_pos) {
[INFO] [stdout]      |         ~~~~~~~~~~~~~~~        ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         if let Some(other_id) = level.has_entity(interact_pos) {
[INFO] [stdout]      |         ~~~~~~~~~~~~        ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]     --> roguelike_engine/src/resolve.rs:1052:25
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         for other_id in level.has_entity(interact_pos) {
[INFO] [stdout]      |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         while let Some(other_id) = level.has_entity(interact_pos) {
[INFO] [stdout]      |         ~~~~~~~~~~~~~~~        ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]      |
[INFO] [stdout] 1052 |         if let Some(other_id) = level.has_entity(interact_pos) {
[INFO] [stdout]      |         ~~~~~~~~~~~~        ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 4 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking roguelike_lib v0.1.0 (/opt/rustwide/workdir/roguelike_lib)
[INFO] [stdout] warning: 7 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking roguelike_main v0.1.0 (/opt/rustwide/workdir/roguelike_main)
[INFO] [stdout] warning: unused import: `roguelike_core::movement::*`
[INFO] [stdout]   --> roguelike_main/src/replay.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | use roguelike_core::movement::*;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `display_state`
[INFO] [stdout]    --> roguelike_main/src/replay.rs:124:16
[INFO] [stdout]     |
[INFO] [stdout] 124 |     let (game, display_state) = recording.backward();
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display_state`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `display_state`
[INFO] [stdout]    --> roguelike_main/src/replay.rs:144:16
[INFO] [stdout]     |
[INFO] [stdout] 144 |     let (game, display_state) = recording.forward().unwrap();
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display_state`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `display_state`
[INFO] [stdout]    --> roguelike_main/src/replay.rs:150:16
[INFO] [stdout]     |
[INFO] [stdout] 150 |     let (game, display_state) = recording.forward().unwrap();
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display_state`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 4 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.92s
[INFO] running `Command { std: "docker" "inspect" "da53ec10afca2042e30b36b9efb0432bc0352087f27823c119f82feaa77c8849", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "da53ec10afca2042e30b36b9efb0432bc0352087f27823c119f82feaa77c8849", kill_on_drop: false }`
[INFO] [stdout] da53ec10afca2042e30b36b9efb0432bc0352087f27823c119f82feaa77c8849
[INFO] checking nsmryan/RustTcodTutorial against try#b4fc5dbf0bc33be331f9d893db5b3a794f29724a+rustflags=-Dexplicit_range -Dtrait_impl_range -Wrange_syntax -Wrange_bounds for pr-121251
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsmryan%2FRustTcodTutorial" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'...
[INFO] [stderr] done.
[INFO] validating manifest of git repo https://github.com/nsmryan/RustTcodTutorial on toolchain b4fc5dbf0bc33be331f9d893db5b3a794f29724a
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b4fc5dbf0bc33be331f9d893db5b3a794f29724a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking git repo https://github.com/nsmryan/RustTcodTutorial
[INFO] finished tweaking git repo https://github.com/nsmryan/RustTcodTutorial
[INFO] tweaked toml for git repo https://github.com/nsmryan/RustTcodTutorial written to /workspace/builds/worker-6-tc2/source/Cargo.toml
[INFO] crate git repo https://github.com/nsmryan/RustTcodTutorial already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b4fc5dbf0bc33be331f9d893db5b3a794f29724a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+b4fc5dbf0bc33be331f9d893db5b3a794f29724a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7977ae272f576360a9925b0ddf130b7479f07a88e178f0c131067986d3252fef
[INFO] running `Command { std: "docker" "start" "-a" "7977ae272f576360a9925b0ddf130b7479f07a88e178f0c131067986d3252fef", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7977ae272f576360a9925b0ddf130b7479f07a88e178f0c131067986d3252fef", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7977ae272f576360a9925b0ddf130b7479f07a88e178f0c131067986d3252fef", kill_on_drop: false }`
[INFO] [stdout] 7977ae272f576360a9925b0ddf130b7479f07a88e178f0c131067986d3252fef
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dexplicit_range -Dtrait_impl_range -Wrange_syntax -Wrange_bounds" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+b4fc5dbf0bc33be331f9d893db5b3a794f29724a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 2f4a3534a0a69f76791492c003af702dc9fbc189a048ec940138ee49fa2dd8bd
[INFO] running `Command { std: "docker" "start" "-a" "2f4a3534a0a69f76791492c003af702dc9fbc189a048ec940138ee49fa2dd8bd", kill_on_drop: false }`
[INFO] [stderr]    Compiling autocfg v1.0.1
[INFO] [stderr]    Compiling proc-macro2 v1.0.36
[INFO] [stderr]    Compiling unicode-xid v0.2.2
[INFO] [stderr]    Compiling syn v1.0.85
[INFO] [stderr]    Compiling memchr v2.5.0
[INFO] [stderr]    Compiling libc v0.2.112
[INFO] [stderr]    Compiling serde_derive v1.0.133
[INFO] [stderr]    Compiling serde v1.0.133
[INFO] [stderr]     Checking hashbrown v0.11.2
[INFO] [stderr]     Checking cfg-if v1.0.0
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling indexmap v1.8.0
[INFO] [stderr]    Compiling regex-syntax v0.6.26
[INFO] [stderr]    Compiling num-integer v0.1.44
[INFO] [stderr]     Checking aho-corasick v0.7.18
[INFO] [stderr]    Compiling once_cell v1.12.0
[INFO] [stderr]    Compiling quote v1.0.14
[INFO] [stderr]     Checking linked-hash-map v0.5.4
[INFO] [stderr]    Compiling log v0.4.14
[INFO] [stderr]     Checking yaml-rust v0.4.5
[INFO] [stderr]    Compiling num-rational v0.3.2
[INFO] [stderr]     Checking ryu v1.0.9
[INFO] [stderr]     Checking either v1.6.1
[INFO] [stderr]     Checking itertools v0.9.0
[INFO] [stderr]     Checking fixedbitset v0.3.2
[INFO] [stderr]     Checking smallvec v1.8.0
[INFO] [stderr]     Checking lazy_static v1.4.0
[INFO] [stderr]     Checking thread-id v3.3.0
[INFO] [stderr]     Checking simple-logging v2.0.2
[INFO] [stderr]    Compiling cfg-if v0.1.10
[INFO] [stderr]    Compiling version-compare v0.0.10
[INFO] [stderr]     Checking getrandom v0.2.4
[INFO] [stderr]     Checking symmetric-shadowcasting v0.2.0
[INFO] [stderr]     Checking byteorder v1.4.3
[INFO] [stderr]    Compiling cc v1.0.72
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]    Compiling sdl2-sys v0.34.5
[INFO] [stderr]     Checking ppv-lite86 v0.2.16
[INFO] [stderr]    Compiling regex v1.5.6
[INFO] [stderr]     Checking pathfinding v2.0.5
[INFO] [stderr]    Compiling sdl2 v0.34.5
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rmp v0.8.10
[INFO] [stderr]     Checking bitflags v1.3.2
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]     Checking bmp v0.5.0
[INFO] [stderr]    Compiling wfc-rs v0.6.1
[INFO] [stderr]    Compiling structmeta-derive v0.1.5
[INFO] [stderr]    Compiling logging_timer_proc_macros v1.1.0
[INFO] [stderr]    Compiling gumdrop_derive v0.8.0
[INFO] [stderr]     Checking logging_timer v1.1.0
[INFO] [stderr]     Checking gumdrop v0.8.0
[INFO] [stderr]    Compiling structmeta v0.1.5
[INFO] [stderr]    Compiling parse-display-derive v0.5.5
[INFO] [stderr]     Checking parse-display v0.5.5
[INFO] [stderr]     Checking serde_yaml v0.8.23
[INFO] [stderr]     Checking rmp-serde v0.15.5
[INFO] [stderr]     Checking roguelike_utils v0.1.0 (/opt/rustwide/workdir/roguelike_utils)
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:169:40
[INFO] [stdout]     |
[INFO] [stdout] 169 |         let range_starting_from_zero = 0..(range.end - range.start);
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: requested on the command line with `-W range-syntax`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:278:40
[INFO] [stdout]     |
[INFO] [stdout] 278 |         let range_starting_from_zero = 0..(range.end - range.start);
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:329:31
[INFO] [stdout]     |
[INFO] [stdout] 329 |         return rng.rand_range(low..high);
[INFO] [stdout]     |                               ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:344:18
[INFO] [stdout]     |
[INFO] [stdout] 344 |     for index in 0..(len - 1) {
[INFO] [stdout]     |                  ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/line.rs:146:14
[INFO] [stdout]     |
[INFO] [stdout] 146 |     for x in 0..dist {
[INFO] [stdout]     |              ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: requested on the command line with `-W range-syntax`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/line.rs:147:18
[INFO] [stdout]     |
[INFO] [stdout] 147 |         for y in 0..dist {
[INFO] [stdout]     |                  ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:169:40
[INFO] [stdout]     |
[INFO] [stdout] 169 |         let range_starting_from_zero = 0..(range.end - range.start);
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:278:40
[INFO] [stdout]     |
[INFO] [stdout] 278 |         let range_starting_from_zero = 0..(range.end - range.start);
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:329:31
[INFO] [stdout]     |
[INFO] [stdout] 329 |         return rng.rand_range(low..high);
[INFO] [stdout]     |                               ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Range` range syntax
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:344:18
[INFO] [stdout]     |
[INFO] [stdout] 344 |     for index in 0..(len - 1) {
[INFO] [stdout]     |                  ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: explicit usage of `Range` type in public function
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:158:41
[INFO] [stdout]     |
[INFO] [stdout] 158 |     pub fn rand_range(&mut self, range: Range<u32>) -> u32 {
[INFO] [stdout]     |                                         ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: requested on the command line with `-D explicit-range`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: explicit usage of `Range` type in public function
[INFO] [stdout]    --> roguelike_utils/src/rng.rs:275:41
[INFO] [stdout]     |
[INFO] [stdout] 275 |     pub fn rand_range(&mut self, range: Range<u64>) -> u64 {
[INFO] [stdout]     |                                         ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 6 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr] error: could not compile `roguelike_utils` (lib) due to 3 previous errors; 4 warnings emitted
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] running `Command { std: "docker" "inspect" "2f4a3534a0a69f76791492c003af702dc9fbc189a048ec940138ee49fa2dd8bd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2f4a3534a0a69f76791492c003af702dc9fbc189a048ec940138ee49fa2dd8bd", kill_on_drop: false }`
[INFO] [stdout] 2f4a3534a0a69f76791492c003af702dc9fbc189a048ec940138ee49fa2dd8bd
